Add throttled value #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jamiewinder Looks great! would you mind adding a few tests? That helps future maintainability :) |
|
I will at some point. Sorry, very lacking for time at the moment! |
|
I think this PR is useful, but big enough to require unit tests. Would you mind either adding them or closing the PR? Thanks! |
Closed
|
Sorry about leaving this to go stale. I'm going to close it as I don't think I'm not a good advocate of it anymore - I don't have any code that uses it now, and have never particularly been a fan of how it worked! Hopefully it can be refined if anyone else found it useful... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code changes for throttledValue function. No tests as yet.