Fix naming of tracking function argument in reaction #398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that the argument in
reaction
was named aspredicate
when it doesn't return a boolean value. Changed this tofn
though we may want to change this something else. Alternatives I can think of aretrackingFunction
/trackingFn
ordataFunction
/dataFn
Sidenote: suggest agreeing on a standard in the API docs. I noticed there are cases where functions are referred to as
<function>
and other places use<function>()
. I would suggest the former and it's also the approach used in the Flutter docs