Fix @observable generic types when using import aliases #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyndman
force-pushed
the
import_alias_generics
branch
3 times, most recently
from
0229a99
to
890f271
Compare
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
==========================================
+ Coverage 97.23% 97.87% +0.64%
==========================================
Files 29 46 +17
Lines 1264 1648 +384
==========================================
+ Hits 1229 1613 +384
Misses 35 35
Continue to review full report at Codecov.
|
shyndman
force-pushed
the
import_alias_generics
branch
from
890f271
to
d259dca
Compare
There were a number of bugs with the previous implementation of the `LibraryScopedNameFinder`. This resolves them, as well as ensures that a single code path is followed whether or not the analyzed source code contains named imports, reducing the potential for future bugs. The following bugs have been corrected when using named imports: * Missing type arguments on classes * Missing type arguments on function typedefs * Missing prefixes from imported typedefs * Missing prefixes from implicit type argument bounds Fixes #367 MR: import_alias_generics
shyndman
force-pushed
the
import_alias_generics
branch
from
d259dca
to
f020acd
Compare
pavanpodila
approved these changes
Jan 17, 2020
|
published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a number of bugs with the previous implementation of the
LibraryScopedNameFinder. This resolves them, as well as ensures that a single code path is followed whether or not the analyzed source code contains named imports, reducing the potential for future bugs.The following bugs have been corrected when using named imports:
Fixes #367