Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds @readonly annotation support to mobx_codegen #649

Merged
merged 6 commits into from
Apr 4, 2021
Merged

Adds @readonly annotation support to mobx_codegen #649

merged 6 commits into from
Apr 4, 2021

Conversation

Ascenio
Copy link
Contributor

@Ascenio Ascenio commented Mar 29, 2021

Continuation of #647.
Replacement of #630.

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #649 (d754e5f) into null_safety (16961a0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           null_safety     #649      +/-   ##
===============================================
+ Coverage        99.16%   99.17%   +0.01%     
===============================================
  Files               52       53       +1     
  Lines             1793     1827      +34     
===============================================
+ Hits              1778     1812      +34     
  Misses              15       15              
Flag Coverage Δ
flutter_mobx 100.00% <ø> (ø)
mobx 99.14% <100.00%> (+0.01%) ⬆️
mobx_codegen 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mobx/lib/src/api/annotations.dart 75.00% <ø> (ø)
mobx_codegen/lib/src/errors.dart 100.00% <100.00%> (ø)
mobx_codegen/lib/src/store_class_visitor.dart 100.00% <100.00%> (ø)
mobx_codegen/lib/src/template/observable.dart 100.00% <100.00%> (ø)
...egen/lib/src/utils/non_private_name_extension.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16961a0...d754e5f. Read the comment docs.

@pavanpodila
Copy link
Member

Now that the branch is merged into master, lets make the PR into master

@Ascenio
Copy link
Contributor Author

Ascenio commented Apr 3, 2021

So, should I make another to master? I thought you could change the target branch of the PR.

@Ascenio Ascenio changed the base branch from null_safety to master April 3, 2021 16:36
@Ascenio
Copy link
Contributor Author

Ascenio commented Apr 3, 2021

Oh, I can too, that's nice, didn't know about that.

@pavanpodila pavanpodila merged commit 4a4b5a6 into mobxjs:master Apr 4, 2021
@pavanpodila
Copy link
Member

@Ascenio, I think you should also create a PR for the docs and describe an example where @readonly would be useful.

@pavanpodila
Copy link
Member

@all-contributors add @Ascenio for code

@allcontributors
Copy link
Contributor

@pavanpodila

I've put up a pull request to add @Ascenio! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants