Remove ObservableSet.linkedHashSetFrom() and use Set by default
#869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mobx ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## master #869 +/- ##
==========================================
+ Coverage 98.80% 98.90% +0.10%
==========================================
Files 55 55
Lines 1925 1920 -5
==========================================
- Hits 1902 1899 -3
+ Misses 23 21 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@fzyzcjy @pavanpodila Please have a look |
fzyzcjy
reviewed
Sep 16, 2022
Co-authored-by: fzyzcjy <5236035+fzyzcjy@users.noreply.github.com>
fzyzcjy
reviewed
Sep 16, 2022
fzyzcjy
approved these changes
Sep 16, 2022
|
Approve after the final change |
pr-1
changed the title
ObservableSet.linkedHashSetFrom() and use LinkedHashSet by defaultObservableSet.linkedHashSetFrom() and use Set by default
pavanpodila
requested changes
Sep 18, 2022
|
resolve conflicts pls before merge @pr-1 |
|
Updated version to 2.0.8 @pavanpodila Please let me know if that is correct or this change should go in patch-count . Resolved conflicts. |
pavanpodila
requested changes
Sep 18, 2022
|
Also there are some hygiene changes being pushed into main. Please take a pull from that as well (possibly in 30 mins). @pr-1 |
pavanpodila
requested changes
Sep 18, 2022
pavanpodila
approved these changes
Sep 18, 2022
tlvenn
pushed a commit
to magelo-labs/mobx.dart_old
that referenced
this pull request
Dec 31, 2022
…obxjs#869) * fix: mobxjs#868 remove linkedHashSetFrom constructor, added tests for ordered hash set Co-authored-by: fzyzcjy <5236035+fzyzcjy@users.noreply.github.com> * fix: directly use Set * removed fixes word * fix: set version using melos Co-authored-by: fzyzcjy <5236035+fzyzcjy@users.noreply.github.com>
tlvenn
pushed a commit
to magelo-labs/mobx.dart_old
that referenced
this pull request
Dec 31, 2022
…obxjs#869) * fix: mobxjs#868 remove linkedHashSetFrom constructor, added tests for ordered hash set Co-authored-by: fzyzcjy <5236035+fzyzcjy@users.noreply.github.com> * fix: directly use Set * removed fixes word * fix: set version using melos Co-authored-by: fzyzcjy <5236035+fzyzcjy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #868.Pull Request Checklist
pubspec.yamlis updated.major/minor/patch/patch-count, depending on the complexity of changeset:versionscommand usingnpmoryarn. You can find this command in thepackage.jsonfile in the root directory