Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-844 #894

Merged
merged 26 commits into from
Feb 16, 2023
Merged

gh-844 #894

merged 26 commits into from
Feb 16, 2023

Conversation

amondnet
Copy link
Collaborator

Describe the changes proposed in this Pull Request.

close #844

close #857
close #858
close #859
close #855
close #864


Pull Request Checklist

  • If the changes are being made to code, ensure the version in pubspec.yaml is updated.
  • Increment the major/minor/patch/patch-count, depending on the complexity of change
  • Add the necessary unit tests to ensure the coverage does not drop
  • Update the Changelog to include all changes made in this PR, organized by version
  • Run the melo run set_version command from the root directory
  • Include the necessary reviewers for the PR
  • Update the docs if there are any API changes or additions to functionality

fzyzcjy and others added 25 commits July 12, 2022 20:59
This reverts commit 263155b.

# Conflicts:
#	mobx/test/computed_test.dart
…alues can be properly disposed mobxjs#857"

This reverts commit bbd9020.
Allow users to bypass observability system for performance; Avoid unnecessary observable notifications of @observable fields of Stores; Fix Reaction lacks toString, so cannot see which reaction causes the error; Add StackTrace to reactions in debug mode to easily spot which reaction it is
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #894 (e64e87d) into master (4400ea1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #894      +/-   ##
==========================================
+ Coverage   98.95%   98.97%   +0.01%     
==========================================
  Files          55       55              
  Lines        1922     1943      +21     
==========================================
+ Hits         1902     1923      +21     
  Misses         20       20              
Flag Coverage Δ
flutter_mobx 100.00% <ø> (ø)
mobx 98.55% <100.00%> (+0.02%) ⬆️
mobx_codegen 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/api/observable_collections/observable_list.dart 100.00% <100.00%> (ø)
...src/api/observable_collections/observable_map.dart 100.00% <100.00%> (ø)
...src/api/observable_collections/observable_set.dart 100.00% <100.00%> (ø)
mobx/lib/src/core/action.dart 100.00% <100.00%> (ø)
mobx/lib/src/core/atom.dart 100.00% <100.00%> (ø)
mobx/lib/src/core/atom_extensions.dart 100.00% <100.00%> (ø)
mobx/lib/src/core/computed.dart 100.00% <100.00%> (ø)
mobx/lib/src/core/context.dart 97.18% <100.00%> (+0.01%) ⬆️
mobx/lib/src/core/observable.dart 100.00% <100.00%> (ø)
mobx/lib/src/core/reaction.dart 98.57% <100.00%> (+0.04%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4400ea1...e64e87d. Read the comment docs.

Copy link
Collaborator

@fzyzcjy fzyzcjy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@amondnet amondnet merged commit d99a5c6 into mobxjs:master Feb 16, 2023
@amondnet amondnet deleted the gh-844 branch February 16, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment