Revert "Alternative solution"

This reverts commit e15bc78.
mobxjs · Sep 24, 2018 · 84b4cd2 · 84b4cd2
1 parent 4808b29
commit 84b4cd2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 25 deletions.
diff --git a/src/core/derivation.ts b/src/core/derivation.ts
@@ -135,8 +135,17 @@ export function isComputingDerivation() {
 }
 
 export function checkIfStateModificationsAreAllowed(atom: IAtom) {
+    const hasObservers = atom.observers.size > 0
+    // Should never be possible to change an observed observable from inside computed, see #798
+    if (globalState.computationDepth > 0 && hasObservers)
+        fail(
+            process.env.NODE_ENV !== "production" &&
+                `Computed values are not allowed to cause side effects by changing observables that are already being observed. Tried to modify: ${
+                    atom.name
+                }`
+        )
     // Should not be possible to change observed state outside strict mode, except during initialization, see #563
-    if (!globalState.allowStateChanges && (atom.observers.size > 0 || globalState.enforceActions === "strict"))
+    if (!globalState.allowStateChanges && (hasObservers || globalState.enforceActions === "strict"))
         fail(
             process.env.NODE_ENV !== "production" &&
                 (globalState.enforceActions

diff --git a/test/base/action.js b/test/base/action.js
@@ -202,30 +202,6 @@ test("should be possible to change observed state in an action called from compu
     d()
 })
 
-test("should be possible to change observed state in an action called from computed if run inside _allowStateChangesInsideComputed - 2", () => {
-    const a = mobx.observable.box(2)
-    const d = mobx.autorun(() => {
-        a.get()
-    })
-
-    const testAction = mobx.action(() => {
-        a.set(3)
-    })
-
-    const c = mobx.computed(() => {
-        mobx._allowStateChanges(true, () => {
-            testAction()
-        })
-        return a.get()
-    })
-
-    c.get()
-
-    mobx._resetGlobalState()
-    d()
-})
-
-
 test("should not be possible to change observed state in an action called from computed", () => {
     var a = mobx.observable.box(2)
     var d = mobx.autorun(() => {