fix: onBecome(Un)Observed didn't trigger (#2076)

mobxjs · Aug 13, 2019 · 8ee9365 · 8ee9365
1 parent 9a40d66
commit 8ee9365
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/src/api/become-observed.ts b/src/api/become-observed.ts
@@ -47,8 +47,8 @@ export function onBecomeUnobserved(thing, arg2, arg3?): Lambda {
 
 function interceptHook(hook: "onBecomeObserved" | "onBecomeUnobserved", thing, arg2, arg3) {
     const atom: IObservable =
-        typeof arg2 === "string" ? getAtom(thing, arg2) : (getAtom(thing) as any)
-    const cb = typeof arg2 === "string" ? arg3 : arg2
+        typeof arg3 === "function" ? getAtom(thing, arg2) : (getAtom(thing) as any)
+    const cb = typeof arg3 === "function" ? arg3 : arg2
     const orig = atom[hook]
 
     if (typeof orig !== "function")

diff --git a/test/base/become-observed.js b/test/base/become-observed.js
@@ -0,0 +1,13 @@
+import { autorun, onBecomeObserved, observable } from "../../src/mobx"
+
+describe("become-observed", () => {
+    it("work on map with number as key", () => {
+        const oMap = observable.map()
+        const key = 1
+        oMap.set(key, observable.box("value"))
+        const cb = jest.fn()
+        onBecomeObserved(oMap, key, cb)
+        autorun(() => oMap.get(key))
+        expect(cb).toBeCalled()
+    })
+})