Merge branch 'main' into fix-2686

mobxjs · Jan 23, 2021 · d9f435f · d9f435f
2 parents c1f4f1d + 592e6e9
commit d9f435f
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 3 deletions.
diff --git a/.changeset/olive-spies-cry.md b/.changeset/olive-spies-cry.md
@@ -0,0 +1,5 @@
+---
+"mobx": patch
+---
+
+The TypeScript type `CreateObservableOptions` is now exported.
diff --git a/.changeset/sweet-shrimps-float.md b/.changeset/sweet-shrimps-float.md
@@ -0,0 +1,7 @@
+---
+"mobx-react-lite": patch
+"mobx-react": patch
+"mobx": patch
+---
+
+Remove `sideEffects` section in `mobx-react-lite` `package.json`
diff --git a/docs/computeds-with-args.md b/docs/computeds-with-args.md
@@ -47,7 +47,8 @@ This is a more efficient implementation compared to the original.
 
 ```javascript
 import * as React from 'react'
-import { observer, computed } from 'mobx-react-lite'
+import { computed } from 'mobx'
+import { observer } from 'mobx-react-lite'
 
 const Item = observer(({ item, store }) => {
     const isSelected = computed(() => store.isSelected(item.id)).get()

diff --git a/docs/installation.md b/docs/installation.md
@@ -16,7 +16,7 @@ There are two types of React bindings, `mobx-react-lite` supports only functiona
 
 **NPM:** `npm install --save mobx`
 
-**CDN:** https://cdnjs.com/libraries/mobx / https://unpkg.com/mobx/lib/mobx.umd.js
+**CDN:** https://cdnjs.com/libraries/mobx / https://unpkg.com/mobx/dist/mobx.umd.production.min.js
 
 ## Use spec compliant transpilation for class properties
 

diff --git a/packages/mobx-react-lite/package.json b/packages/mobx-react-lite/package.json
@@ -22,7 +22,6 @@
         "README.md",
         "batching*"
     ],
-    "sideEffects": false,
     "repository": {
         "type": "git",
         "url": "https://github.com/mobxjs/mobx.git"

diff --git a/packages/mobx/src/mobx.ts b/packages/mobx/src/mobx.ts
@@ -73,6 +73,7 @@ export {
     transaction,
     observable,
     IObservableFactory,
+    CreateObservableOptions,
     computed,
     isObservable,
     isObservableProp,