Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 11 support #2812

Closed
popec opened this issue Feb 17, 2021 · 3 comments
Closed

Angular 11 support #2812

popec opened this issue Feb 17, 2021 · 3 comments
Labels

Comments

@popec
Copy link

popec commented Feb 17, 2021

We're on Angular 11 with mobx-angular and getting JS error with "aot": true and "optimization": true, "buildOptimizer": true
TypeError: t.make_ is not a function

It works when:
we set aot: false
or
we set aot: true, optimization: false
or
we set aot: true, optimization: true, buildOptimizer: false (which is our current solution)
Any chances for Angular 11 with buildOptimizer enabled support?

@popec popec added the 🐛 bug label Feb 17, 2021
@urugator
Copy link
Collaborator

urugator commented Feb 17, 2021

As you've already noticed there is already an issue in a mobx-angular repo
Is there some bug that prevents integration with angular?

@popec
Copy link
Author

popec commented Feb 17, 2021

It doesn't work when buildOptimizer is true in angular.json, otherwise it works.

@mweststrate
Copy link
Member

unless there is any reason to assume this is a bug in Mobx itself, lets stick to to the issue in mobx-angular.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants