Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Angular 10 and above #127

Closed
th0r opened this issue Nov 16, 2020 · 4 comments
Closed

Support Angular 10 and above #127

th0r opened this issue Nov 16, 2020 · 4 comments

Comments

@th0r
Copy link

th0r commented Nov 16, 2020

Current version of this package supports only v9:

"@angular/common": "^9.0.1",
"@angular/core": "^9.0.1",

It would be great to also support Angular 10 and above.

@popec
Copy link

popec commented Feb 17, 2021

We're on Angular 11 and getting JS error with "aot": true and "optimization": true, "buildOptimizer": true
TypeError: t.make_ is not a function
It works when:

  • we set aot: false
    or
  • we set aot: true, optimization: false
    or
  • we set aot: true, optimization: true, buildOptimizer: false (which is our current solution)

Any chances for Angular 11 with buildOptimizer enabled ?

@reidkornman
Copy link

Sticking to the root of this ask... when will Angular 11 support be consider/added?

@adamkleingit
Copy link
Member

Anyone wants to try and solve this and open a PR?
@popec @reidkornman @th0r
It would be much appreciated. Thanks!

adamkleingit added a commit that referenced this issue Mar 5, 2021
Added support for Angular v11. Closes #127
@popec
Copy link

popec commented Mar 25, 2021

It's not helping, same thing happens after building app with buildOptimizer: true in angular.json as before.
It's probably mobx itself not being ok with uglify maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants