Flow JS Types not longer exported in package build? (Upgrade MobX 4 -> 6)

[alexander-schranz]

I currently try to update Mobx 4 to 6. In my js configuration before I did import the types from:

import type {IObservableValue} from 'mobx/dist/mobx';

@observer
class MediaOverview extends React.Component<ViewProps> {
    collectionPage: IObservableValue<number> = observable.box();
    mediaPage: IObservableValue<number> = observable.box();
    locale: IObservableValue<string> = observable.box();

But it seems like there exist not longer a flow typing in the exported package as the flow-types not there.

Intended outcome:

That the flow types are still exported:

https://github.com/mobxjs/mobx/tree/mobx%406.10.2/packages/mobx/flow-typed

Actual outcome:

No flow types exported:

mobx/packages/mobx/package.json

Lines 15 to 21 in bbd6099

	"files": [
	"src",
	"dist",
	"LICENSE",
	"CHANGELOG.md",
	"README.md"
	],

How to reproduce the issue:

Try to import flow types for mobx.

Versions

6.10.2 and 6.11.0 tested.

[mweststrate]

Since flow-types are hand written, and TS has become the industry standard as well stopped maintaining the Flow types so I think the file is still just accidentally there, but it is not up to date anymore.

…

On Sat, Nov 25, 2023 at 3:17 PM Alexander Schranz ***@***.***> wrote: I currently try to update Mobx 4 to 6. In my js configuration before I did import the types from: import type {IObservableValue} from 'mobx/dist/mobx'; @observer class MediaOverview extends React.Component<ViewProps> { collectionPage: IObservableValue<number> = observable.box(); mediaPage: IObservableValue<number> = observable.box(); locale: IObservableValue<string> = observable.box(); But it seems like there exist not longer a flow typing in the exported package as the flow-types not there. *Intended outcome:* That the flow types are still exported: https://github.com/mobxjs/mobx/tree/mobx%406.10.2/packages/mobx/flow-typed *Actual outcome:* No flow types exported: https://github.com/mobxjs/mobx/blob/bbd6099eef40b5876d2a004a312fff457a140fec/packages/mobx/package.json#L15-L21 *How to reproduce the issue:* Try to import flow types for mobx. *Versions* 6.10.2 and 6.11.0 tested. — Reply to this email directly, view it on GitHub <#3802>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAN4NBC6MHST325UUJWGA4LYGH4X3AVCNFSM6AAAAAA72ECYFSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYTANRXGE2TAOA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>