Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transaction function has no try/finally block #603

Closed
plinyar opened this issue Oct 9, 2016 · 2 comments
Closed

transaction function has no try/finally block #603

plinyar opened this issue Oct 9, 2016 · 2 comments
Labels

Comments

@plinyar
Copy link

plinyar commented Oct 9, 2016

I got an exception inside a code block wrapped in transaction function, after that reactions stopped working.
Problem was found that the function increments globalState.inTransaction and then decrements it without try/finally block.

@mweststrate
Copy link
Member

You are right. Should be addressed here:

const res = action.call(thisArg);

@mweststrate
Copy link
Member

Fixed in mobx@2.6.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants