fix issues 1980 and 2003

[haimrait]

Fix issues #1980 and #2003.

[mweststrate]

Great PR, thanks!

[danielkcz]

I guess no need to hold it longer here since you got approval from the highest authority :)

Can you also prepare PR to mobx4-master branch, please?

[urugator]

Thanks for the PR! I see it's based on the snippet I posted, but you removed the part which was supposed to notify observers when only the order is changed. A situation like this:

const map = observable.map({ a: "a", b: "b" });
autorun(() => map.entries());
map.replace({ b: "b", a: "a" }); // should invoke autorun

Is it handled correctly? Do we have a test for that?

[haimrait]

Yea... I checked this issue and it invokes autorun one time for your case.

[haimrait]

@FredyC I made a pr for mobx4- master branch
#2058

[urugator]

Yea... I checked this issue and it invokes autorun one time for your case.

Interesting... I wonder what invalidates the reaction then ... this.delete isn't called and this.set shouldn't since the value isn't modified (or keys)...

[danielkcz]

@mweststrate I see you are on issue spree but don't publish V5 right now. Chances are it's actually broken, see #2058

[mweststrate]

:) I won't, but I'm not the only publisher in here, so probably best to revert that merge, and then immediately open a PR with a revert of the revert, linking to here

…

On Fri, Jul 26, 2019 at 8:58 PM Daniel K. ***@***.***> wrote: @mweststrate <https://github.com/mweststrate> I see you are on issue spree but don't publish V5 right now. Chances are it's actually broken, see #2058 <#2058> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2057?email_source=notifications&email_token=AAN4NBGS6GSBZPPXUJEAFSDQBNCODA5CNFSM4IGZJ2QKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD25OCYI#issuecomment-515563873>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAN4NBE5A753MKHF4NRSZD3QBNCODANCNFSM4IGZJ2QA> .