Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pitfalls.ms #2226

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Update pitfalls.ms #2226

merged 1 commit into from
Dec 9, 2019

Conversation

clehene
Copy link
Contributor

@clehene clehene commented Dec 9, 2019

@Inject must preceed @observer

Thanks for taking the effort to create a PR!

If you are creating an extensive PR, you might want to open an issue with your idea first, so that you don't put a lot of effort in an PR that wouldn't be accepted. Please prepend pull requests with WIP: if they are not yet finished
PR checklist:

  • Added unit tests
  • Updated changelog
  • Updated /docs. For new functionality, at least API.md should be updated
  • Added typescript typings
  • Verified that there is no significant performance drop (npm run perf)

Feel free to ask help with any of these boxes!

The above process doesn't apply to doc updates etc.

@danielkcz
Copy link
Contributor

Thanks, it makes sense to have that in there.

@danielkcz danielkcz merged commit b409ace into mobxjs:master Dec 9, 2019
@clehene clehene deleted the patch-1 branch December 9, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants