Union type in actions #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solve #255.
<type>ModelSelectorfile for unions (unions don't generate an actual Model or Model.base file and I was following the pattern of putting the extra stuff in this file)<type>Unionto theRootStore.base.tsfile for use in actionsqueryHelperfunction to use the correct type if the action is using a field that isUNIONIn order to test this out, I added an example
searchfield in the twitter example (only server side right now). It uses a union type of User and Message to return results, which creates a new action in theRootStore.base.ts. I also tested out the generation in another project (my own) which also generates correct types.