Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade graphql package #367

Merged
merged 5 commits into from
May 6, 2022
Merged

Conversation

beepsoft
Copy link
Collaborator

@beepsoft beepsoft commented May 6, 2022

Upgrades graphql to "^16.3.0" so that it works with new CRA apps, which use webpack 5.

Added tests/test-cra.sh, which creates a new CRA app with the latest mst-gql and the necessary dependencies, checks whether generation, tsc compilation and running the app succeeds.

Fixes #365.

It seems to work, but need to update tests as well.
Instead of graphql.introspectionQuery we now need to use
getIntrospectionQuery()
It can be used to test mst-gql in a new CRA app with all new dependencies.
Run when "yarn test" is called.
@jesse-savary jesse-savary merged commit c6396e7 into mobxjs:main May 6, 2022
@beepsoft
Copy link
Collaborator Author

beepsoft commented May 7, 2022

Oops, I accidentally committed it with

"version": "0.15.0-361-graphql-upgrade"

You may want to change that to 0.15.1 or something.

@beepsoft
Copy link
Collaborator Author

beepsoft commented May 7, 2022

Or better the next release should be 0.16.0, because the graphql upgrade is a breaking change, I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error using in Create-React-App
2 participants