Fix serializations of nulls in list

mobxjs · Oct 17, 2022 · 85495d7 · 85495d7
1 parent ce47d9c
commit 85495d7
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/src/types/list.ts b/src/types/list.ts
@@ -54,10 +54,16 @@ export default function list(
             if (ar === undefined) {
                 return SKIP;
             }
+            if (ar === null) {
+                return null;
+            }
+
             invariant(ar && "length" in ar && "map" in ar, "expected array (like) object");
             return ar.map(propSchema.serializer);
         },
         deserializer: function (jsonArray, done, context) {
+            if (jsonArray === null) return void done(null, jsonArray);
+
             if (!Array.isArray(jsonArray)) return void done("[serializr] expected JSON array");
 
             function processItem(

diff --git a/test/simple.js b/test/simple.js
@@ -333,6 +333,19 @@ test("it should respect lists", (t) => {
     t.end()
 })
 
+test("it should respect lists when null", (t) => {
+    var schema = _.createSimpleSchema({
+        x: _.list(primitive()),
+    })
+
+    var source = { x: null }
+    var json = source
+    t.deepEqual(serialize(schema, source), json)
+    t.deepEqual(deserialize(schema, json), source)
+
+    t.end()
+})
+
 test("it should respect childs", (t) => {
     var childSchema = _.createSimpleSchema({
         x: primitive(),