Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prettify js within readme, fix typos #43

Merged
merged 2 commits into from
Jun 13, 2017
Merged

Prettify js within readme, fix typos #43

merged 2 commits into from
Jun 13, 2017

Conversation

brikou
Copy link
Contributor

@brikou brikou commented Apr 25, 2017

I found typos in JS in readme so I fixed those and also prettify everything to have a consistent coding style.

Thank you for you hard work @mweststrate with this lib 👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.995% when pulling c9f6de4 on brikou:pretty_readme into f73085d on mobxjs:master.

@mweststrate
Copy link
Member

mweststrate commented Apr 25, 2017 •
edited
Loading

Thanks! Note that the examples for specific api methods are generated from source, so should be updated in the @example sections in the source code

@brikou
Copy link
Contributor Author

brikou commented Apr 25, 2017

Done

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.995% when pulling 555dd72 on brikou:pretty_readme into f73085d on mobxjs:master.

@brikou
Copy link
Contributor Author

brikou commented Apr 26, 2017

@mweststrate is this fine for you ?

@mweststrate
Copy link
Member

Perfect! Thanks a lot

@mweststrate mweststrate merged commit 94bd40b into mobxjs:master Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brikou @coveralls @mweststrate