Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed up time of resolve image config for docker.io/docker/dockerfile:1.3.0 #2313

Closed
beastpu opened this issue Aug 17, 2021 · 12 comments
Closed

Comments

@beastpu
Copy link

beastpu commented Aug 17, 2021

how can i reduce time of resolve image?

#3 resolve image config for docker.io/docker/dockerfile:1.3.0
#3 sha256:8d127e04b6cfdde1229e691aaf2fc892eb234fb4ad4a5a1f4e9435df76031d4e
#3 DONE 31.1s

@tonistiigi
Copy link
Member

from last CI run in this repo

#2 resolve image config for docker.io/docker/dockerfile:1.3
#2 DONE 0.4s

@joncfoo
Copy link

joncfoo commented Aug 19, 2021

Another example:

=> resolve image config for docker.io/docker/dockerfile:1.3          155.7s

@crazy-max
Copy link
Member

@beastpu @joncfoo What kind of credentials store are you using: cat ~/.docker/config.json | jq -r '.credsStore'? (just making some assumptions here).

@joncfoo
Copy link

joncfoo commented Aug 19, 2021

desktop

@crazy-max
Copy link
Member

@joncfoo Can you remove the "credsStore" entry in the config file then docker login and run your build again?

@joncfoo
Copy link

joncfoo commented Aug 19, 2021

That seems to do the trick 🤷 . Now it resolves instantaneously. What do you think is going on?

@joncfoo
Copy link

joncfoo commented Aug 19, 2021

Also, thank you @crazy-max!

@crazy-max
Copy link
Member

crazy-max commented Aug 19, 2021

Might be a syscall issue with wincred (cc @thaJeztah). I've opened a PR danieljoos/wincred#22 to use the most recent sys pkg. Can you give me the output of systeminfo (with cmd) please (OS Name/Version)?

OS Name:              Microsoft Windows 11 Professionnel
OS Version:           10.0.22000 N/A build 22000

@joncfoo
Copy link

joncfoo commented Aug 20, 2021

I’m not using Windows; on macOS

@crazy-max
Copy link
Member

@joncfoo My bad, indeed desktop is docker-credential-desktop so it might be an issue with it and not wincred or osxkeychain. After further tests I can confirm:

{
	"auths": {
		"https://index.docker.io/v1/": {}
	},
	"credsStore": "desktop.exe"
}
=> resolve image config for docker.io/docker/dockerfile:1.3          21s

{
	"auths": {
		"https://index.docker.io/v1/": {}
	},
	"credsStore": "wincred.exe"
}
=> resolve image config for docker.io/docker/dockerfile:1.3          1.2s

cc @djs55 @rumpl

@LeviPesin
Copy link

LeviPesin commented Feb 16, 2023

Having the same issue on Windows (the resolve does not finish faster than about 200 seconds).
Had this in config.json:

{
  "credsStore": "desktop"
}

Changed to {}, same.

@piaolingxue
Copy link

Having the same issue on Mac

 => resolve image config for docker.io/docker/dockerfile:1.4       17.9s

Had this in config.json:

{
  "credsStore": "desktop"
}

Changed to {}, same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants