-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go.mod: update docker-credential-helpers v0.7.0 #9936
Conversation
b607233
to
0667555
Compare
Codecov ReportBase: 74.56% // Head: 74.56% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## v2 #9936 +/- ##
=======================================
Coverage 74.56% 74.56%
=======================================
Files 2 2
Lines 232 232
=======================================
Hits 173 173
Misses 51 51
Partials 8 8 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
let me rebase |
The file had multiple "requires" blocks, which made it harder to find which dependencies were used. Some direct modules also were in the "indirect" block. While updating, also updated some comments. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
BuildKit and Buildx no longer require this replace rule (it probably only was needed in buildkit, which used this version to compile). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
to match the version used by the cli (the cli doesn't use go.mod, so go modules doesn't automatically pick that up); https://github.com/docker/cli/blob/1d6c6e2367e292950e483e3c8ace142792bca718/vendor.mod#L14 Used code doesn't change, but we want to keep the older github.com/danieljoos/wincred v1.1.0 out of the dependency tree :) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
0667555
to
c630c8d
Compare
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
go.mod: update docker-credential-helpers v0.7.0
to match the version used by the cli (the cli doesn't use go.mod, so go modules
doesn't automatically pick that up);
https://github.com/docker/cli/blob/1d6c6e2367e292950e483e3c8ace142792bca718/vendor.mod#L14
Used code doesn't change, but we want to keep the older github.com/danieljoos/wincred v1.1.0
out of the dependency tree :)
Other changes:
go mod: tidy and group "require" blocks, update comments
The file had multiple "requires" blocks, which made it harder to find which
dependencies were used. Some direct modules also were in the "indirect" block.
go.mod: remove replace for runc
BuildKit and Buildx no longer require this replace rule (it probably only was
needed in buildkit, which used this version to compile).
What I did
Related issue
golang.org/x/sys
danieljoos/wincred#22(not mandatory) A picture of a cute animal, if possible in relation with what you did