-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: csv syntax for git repos #4905
Comments
FWIW, the simpler answer to this is to use full/explicit refs instead of abbreviated ones ( (IMO [not a buildkit maintainer], it would be weird to invent buildkit-specific syntax sugar for these refs such that |
As @tianon said this can already be done with setting full ref. Additionally, I think builds from refs like
This looks like too much sugar to me. You can't do
Don't exactly get what case you have in mind here. Downsides:
Potential opportunities with CSV format:
|
Agreeing on all points.
I understand this is today's behavior WRT image tags. I would argue that some kind of check that ensures that the given digest exists in/among/as the given constraint (at least once, some time in the past). e.g. make sure $commit exists on $branch. I remember a beforetime when GitHub would be fine showing commits from some fork as commits of the upstream, trusted repo. |
Ran into an issue today that's relevant here -- I've got a repo I need to build a Something like this would be an interesting way to allow non-recursive clone (which is what I need, in my case, and isn't something we can reasonably auto-detect). Edit: filed #4974 explicitly for this, because it's orthogonal (even though this could be one possible solution for it) |
Today's way of expressing remote Git repos as contexts
does not allow
$IMAGE_URL:mytag@sha256:cafebabe..
)renovate
provide a way to upgrade digests givenmytag
To permit this I propose to extend this syntax in a somewhat backwards compatible way:
tag
andbranch
cannot be used togethercommit
can be a short commit hash instead of a full one/
forsource
: to keep with uniformity with other csv args##
usage (instead of just#
) may already exist in the wild (but "unlikely" combined with csv)renovate
can work withbranch
ortag
(git tags are as mutable as branches) andcommit
, as with imagesThe text was updated successfully, but these errors were encountered: