Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildkitd: use asyncremove on overlay #1007

Merged
merged 1 commit into from
May 22, 2019

Conversation

tonistiigi
Copy link
Member

related to #991

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi
Copy link
Member Author

@msg555 can you check this patch for #991

Copy link
Collaborator

@tiborvass tiborvass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From looking at containerd code this looks alright, but I'd prefer other eyes given I'm not able to reproduce the issue.

@msg555
Copy link
Contributor

msg555 commented May 15, 2019

It does not appear to reconcile #991, I'll post some more logs with this PR to the issue shortly.

@msg555 msg555 mentioned this pull request May 15, 2019
@tiborvass tiborvass merged commit 32918be into moby:master May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants