worker: fix gc race on fromremote #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm that this patch made my build success rate go from 0 of 20 to 19 of 20. Seems to address the main issue I was running into. The one remaining failure seems to be an entirely different issue. |
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
fromremote-gc-race
branch
from
dc497b4
to
276fee0
Compare
AkihiroSuda
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #991
Fixes issue when gc/prune runs in the middle of the cache import. The issue is that if the imported record already exists it is skipped on unpack but might be released before the reference is taken on the unpacked records. Fix is to take a ref temporarily on unpack if it exists.
I think there are still small cases that can go wrong on pull, eg. when there is an extra condition with multiple blobs matching same snapshot. I want to refactor the whole cache record management on top of containerd/containerd#3304 that should fix all of these races. Hopefully this should be good enough fix all the practical cases where this issue can turn up.
@msg555