llbsolver: add more llb validation #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
force-pushed
the
llb-validation
branch
from
bf38147
to
2511b39
Compare
ehotinger
reviewed
Jun 18, 2019
solver/llbsolver/vertex.go
Outdated
| } | ||
| case *pb.Op_Build: | ||
| if op.Build == nil { | ||
| return errors.Errorf("invalid nil build op ") |
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
llb-validation
branch
from
2511b39
to
5fc18fd
Compare
tiborvass
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1030
closes #1031
closes #1037
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com