Fix socket handling #1144
Merged
Fix socket handling #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiborvass
force-pushed
the
fsutil-sockets
branch
3 times, most recently
from
c2b6eb6
to
9e362e2
Compare
added 3 commits
August 27, 2019 20:53
Signed-off-by: Tibor Vass <tibor@docker.com>
Signed-off-by: Tibor Vass <tibor@docker.com>
Signed-off-by: Tibor Vass <tibor@docker.com>
tiborvass
force-pushed
the
fsutil-sockets
branch
from
9e362e2
to
aa3ad5f
Compare
AkihiroSuda
approved these changes
Aug 28, 2019
tonistiigi
approved these changes
Aug 29, 2019
This was referenced Sep 20, 2019
This was referenced Sep 24, 2019
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Oct 24, 2019
full diff: moby/buildkit@f704282...ae10b29 fixes: - moby/buildkit#1144 Fix socket handling - fsutil: Handle copying unix sockets in local sources - update github.com/containerd/continuity to 75bee3e2ccb6 - update github.com/tonistiigi/fsutil to 3d2716dd0a4d - moby/buildkit#1150 ssh: Fix file descriptor leak when doing SSH forwarding - fixes moby/buildkit#1146 SSH Forwarding Doesn't Release File Descriptors - moby/buildkit#1156 llbsolver: Fix using multiple remote cache importers - moby/buildkit#1159 http: Handle missing but unambiguous ETags in response - fixes moby/buildkit#905 ADD from url fails with 'invalid not-modified ETag' - fixes moby/buildkit#784 invalid not-modified ETag with local network ADD in docker - moby/buildkit#1166 solver: Fix possible inefficient parallelization in solver - fix cases where some events were dropped resulting inefficient parallelization. - moby/buildkit#1168 vendor: update go-runc to e029b79d - moby/buildkit#1140 contenthash: Fix bug with symlink in source path of a copy operation - fixes moby/buildkit#974 COPY --from fails when source path involves a symlink - fixes moby/buildkit#785 COPY rpc error: code = Unknown desc = not found: not found - fixes moby/buildkit#958 Issue COPY a file to a symlink directory - moby/buildkit#1139 executor: oom_score_adj is no longer set from main process Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Jan 13, 2020
full diff: tonistiigi/fsutil@3bbb99c...0f039a0 - tonistiigi/fsutil#66 copy: add fast copy path for darwin - tonistiigi/fsutil#67 Treat Unix sockets as regular files - relates to moby/buildkit#1144 Fix socket handling - tonistiigi/fsutil#68 fix gocrypto commit - tonistiigi/fsutil#69 receive: use filter on receive diff - prevents incremental transfers with userns because the metadata on disk is always different than the one being transferred. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Jan 13, 2020
full diff: tonistiigi/fsutil@3bbb99c...0f039a0 - tonistiigi/fsutil#66 copy: add fast copy path for darwin - tonistiigi/fsutil#67 Treat Unix sockets as regular files - relates to moby/buildkit#1144 Fix socket handling - tonistiigi/fsutil#68 fix gocrypto commit - tonistiigi/fsutil#69 receive: use filter on receive diff - prevents incremental transfers with userns because the metadata on disk is always different than the one being transferred. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 94a8c8b3c09540497f6fb7a3d40de80610c920ac Component: engine
alexcb
added a commit
to alexcb/buildkit
that referenced
this pull request
Jul 23, 2020
This fix is similar to the fix in moby#1144; but was hit in a different code path. Signed-off-by: Alex Couture-Beil <alex@earthly.dev>
alexcb
added a commit
to alexcb/buildkit
that referenced
this pull request
Jul 23, 2020
This fix is similar to the fix in moby#1144; but was hit in a different code path. Signed-off-by: Alex Couture-Beil <alex@earthly.dev>
alexcb
added a commit
to alexcb/buildkit
that referenced
this pull request
Jul 23, 2020
This fix is similar to the fix in moby#1144; but was hit in a different code path. Signed-off-by: Alex Couture-Beil <alex@earthly.dev>
fahedouch
pushed a commit
to fahedouch/buildkit
that referenced
this pull request
Nov 8, 2020
This fix is similar to the fix in moby#1144; but was hit in a different code path. Signed-off-by: Alex Couture-Beil <alex@earthly.dev> Signed-off-by: fahed dorgaa <fahed.dorgaa@gmail.com>
fahedouch
pushed a commit
to fahedouch/buildkit
that referenced
this pull request
Nov 9, 2020
This fix is similar to the fix in moby#1144; but was hit in a different code path. Signed-off-by: Alex Couture-Beil <alex@earthly.dev> Signed-off-by: fahed dorgaa <fahed.dorgaa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests and vendors tonistiigi/fsutil#67
Also vendors containerd/continuity#143