resolver: support self signed certificates #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Mar 16, 2020
AkihiroSuda
reviewed
Mar 16, 2020
AkihiroSuda
reviewed
Mar 16, 2020
| PlainHTTP *bool `toml:"http"` | ||
| Insecure *bool `toml:"insecure"` | ||
| RootCAs []string `toml:"ca"` | ||
| KeyPairs []TLSKeyPair `toml:"keypair"` |
There was a problem hiding this comment.
All of them are arrays really 🤷♂
There was a problem hiding this comment.
Looking at the toml it actually makes more sense to keep it singular for complex types because they need to be defined one-by-one and plural for simple types. Already quite a mess though.
AkihiroSuda
reviewed
Mar 16, 2020
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
self-signed-tls
branch
from
cd75551
to
56f76a5
Compare
AkihiroSuda
approved these changes
Mar 17, 2020
This was referenced Apr 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com