-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dockerfile: update run mounts to stable channel #1717
Conversation
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
a11a3ff
to
906e345
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but left one question
@@ -90,7 +90,7 @@ fi | |||
DOCKERFILE_RELEASES_CUSTOM="" | |||
if [ "$TEST_DOCKERFILE" == 1 ]; then | |||
if [ -z $DOCKERFILE_RELEASES ]; then | |||
DOCKERFILE_RELEASES="mainline experimental mounts secrets ssh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add mounts
, secrets
, and ssh
as aliases for the stable
image, so that dockerfiles that refer that syntax will get the current stable, and not some outdated version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or perhaps also ignore the syntax
for current versions as it would now be the default, so don't (try to ) pull the frontend?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as DockerHub doesn't GC the latest mounts
, secrets
, and ssh
images, I think it's fine? I think if secrets suddenly is supported on the mounts
image that would be more confusing as an user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no mounts
, secrets
channel in dockerhub. Only daily builds that in dockerfile-upstream
are timestamped already.
fix #1675
@AkihiroSuda @hinshun @tiborvass @thaJeztah
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com