frontend: add some dockerfile integration tests #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
dockerfile-tests
branch
from
ad197c4
to
bcc98bf
Compare
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
dockerfile-tests
branch
2 times, most recently
from
a7c68a9
to
c29f08d
Compare
AkihiroSuda
reviewed
Dec 1, 2017
cmd/buildctl/build_test.go
Outdated
| rdr, err := marshal(st.Root()) | ||
| require.NoError(t, err) | ||
|
|
||
| cmd := sb.Cmd("build --no-progress --exporter=image --exporter-opt name=docker.io/moby/imageexporter:test") |
There was a problem hiding this comment.
nit: Do we have an access for https://hub.docker.com/u/moby/ ?
If not, could you use another name? (example.com/moby/imageexporter:test?)
AkihiroSuda
reviewed
Dec 1, 2017
cmd/buildctl/build_test.go
Outdated
| err = cmd.Run() | ||
| require.NoError(t, err) | ||
|
|
||
| cmd = exec.Command("ctr", "--address", cdAddress, "--namespace=buildkit", "images", "ls") |
There was a problem hiding this comment.
Can we use containerd client library rather than ctr, which is unsupported and hard to parse the result.
AkihiroSuda
reviewed
Dec 1, 2017
| address string | ||
| } | ||
|
|
||
| func (s *cdsandbox) ContainerDAddress() string { |
There was a problem hiding this comment.
nit: ContainerD -> Containerd?
tonistiigi
force-pushed
the
dockerfile-tests
branch
from
c29f08d
to
09ef88c
Compare
|
@AkihiroSuda updated |
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
dockerfile-tests
branch
from
09ef88c
to
97b773a
Compare
AkihiroSuda
approved these changes
Dec 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com
edit: Added more commits to same PR for testing: