solver: fix slow-cache status tracking with preprocess #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preprocess should not be taken into account when calculating cache-slow state. But it should be used to detect if dep is complete so preprocess runs before parent's exec function. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
scheduler-fix-for-testing
branch
from
81ac853
to
2f247f0
Compare
tonistiigi
changed the title
tiborvass
reviewed
Dec 11, 2020
| @@ -604,10 +605,10 @@ func (e *edge) recalcCurrentState() { | |||
| } | |||
| } | |||
| effectiveState := dep.state | |||
| if dep.state == edgeStatusCacheSlow && isSlowIncomplete { | |||
| if dep.state == edgeStatusCacheSlow && isSlowCacheIncomplete { | |||
There was a problem hiding this comment.
if isSlowCacheIncomplete && (dep.state == edgeStatusCacheSlow || dep.state == edgeStatusComplete) {
effectiveState = edgeStatusCacheFast
}
tiborvass
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7061291 from #1863 with some modification.
Preprocess should not be taken into account when calculating
cache-slow state. But it should be used to detect if dep is complete
so preprocess runs before parent's exec function.
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com