Cache Auth errors for 1 second

[alexcb]

• previously auth errors were being cached indefinitely.

fixes #1928

Signed-off-by: Alex Couture-Beil alex@earthly.dev

[tonistiigi]

Not ideal to have time-based constants where behavior changes on different machines/load. If the real solution is complicated we could let this in as a temp fix.

[alexcb]

I agree it's a bit hacky, I'm unsure how to limit the cache for a single build without just disabling all caching of errors completely; would it be better to decrease this time-based retry limiter to something less than a second (e.g. Millisecond, microsecond). The smaller the time-based backoff, the closer we get to completely disabling the caching of errors.

[tonistiigi]

I'm fine with disabling caching for errors at all as a concept but some analysis needs to be made that this doesn't cause any issues for the parallel builds logic, multiple requests per pull, and for the request retries.