allow skipping empty layer detection on cache export #1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tiborvass
approved these changes
Feb 24, 2021
tiborvass
pushed a commit
to thaJeztah/docker
that referenced
this pull request
Feb 25, 2021
See moby/buildkit#1993 Signed-off-by: Tibor Vass <tibor@docker.com>
tiborvass
pushed a commit
to thaJeztah/docker
that referenced
this pull request
Feb 25, 2021
See moby/buildkit#1993 Signed-off-by: Tibor Vass <tibor@docker.com> (cherry picked from commit 9bf93e9) Signed-off-by: Tibor Vass <tibor@docker.com>
docker-jenkins
pushed a commit
to docker/docker-ce
that referenced
this pull request
Feb 25, 2021
See moby/buildkit#1993 Signed-off-by: Tibor Vass <tibor@docker.com> Upstream-commit: 9bf93e90fa9ce74b6f7309a22838da8189838b3b Component: engine
sergioprado
pushed a commit
to toradex/torizoncore-builder
that referenced
this pull request
Aug 25, 2021
The build of the container sometimes fails with the following error: failed to compute cache key: failed to walk /var/lib/docker/overlay2/df6ea.../merged/root/aktualizr/build: lstat /var/lib/docker/overlay2/df6ea.../merged/root/aktualizr/build: no such file or directory It seems a cache issue with the sota-builder build stage. For some reason, using --cache-from with BUILDKIT_INLINE_CACHE does not work every time. Indeed, there is a report of this issue in [1] and it is fixed in [2], but it seems our CI it's not running a Buildkit version that has this fix. To workaround this issue, let's disable cached builds for now. [1] moby/buildkit#1981 [2] moby/buildkit#1993 Related-to: TOR-1671 Signed-off-by: Sergio Prado <sergio.prado@toradex.com>
nosamad
pushed a commit
to WAGO/docker-engine
that referenced
this pull request
Sep 13, 2021
See moby/buildkit#1993 Signed-off-by: Tibor Vass <tibor@docker.com> (cherry picked from commit 9bf93e9) Signed-off-by: Tibor Vass <tibor@docker.com>
nosamad
pushed a commit
to WAGO/docker-engine
that referenced
this pull request
Sep 15, 2021
See moby/buildkit#1993 Signed-off-by: Tibor Vass <tibor@docker.com> (cherry picked from commit 9bf93e9) Signed-off-by: Tibor Vass <tibor@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1992
Moby image exporter does not remove empty layers causing inline cache to go out of sync. This allows behavior to be configured so it can be turned off in moby.
Regression from 85dd12d
There is still an issue that empty layers (ones optimized after differ, not metadata commands) can get out of sync in the history array of the image after cache import. Don't really know what to do about it as there is no information to determine that a
RUNcommand didn't create a layer without running it.Signed-off-by: Tonis Tiigi tonistiigi@gmail.com