-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure exporter progress logs are properly keyed #2953
Conversation
605a5a1
to
3b06d0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now they are only unique based on image export of cache export. I don't understand how this is related to the bake
problem in the initial comment.
This patch ensures that all progress outputs for exporters are properly keyed uniquely to the session, to ensure that duplicate exporters across different sessions do not conflict and produce confusing results. Currently, this behavior isn't relied upon by buildkit, but is used by buildx bake, where multiple image exporters might be invoked at the same time. Signed-off-by: Justin Chadwell <me@jedevc.com>
3b06d0c
to
f7922fb
Compare
Woops, have split out the cache inline cache properly as well. The cache exports need to be properly split out similarly, or we see the same kind of issue for inline cache:
vs
and for the other cache types:
vs
Essentially, we need to force the logs here to be unique per session (previously they were derived exclusively from the exporter's |
Fixes an issue with bake's progress output, where multiple exporters of the same type might be invoked, resulting in the logs writing over each other within the same section. Additionally, this will be important in the context of #2760, where the progress logs per output need to be appropriately separated.
Sample bake file:
Before:
After: