Pass platform arg for stage state to ContextByName #2990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cpuguy83 The test seems to be failing in CI |
cpuguy83
force-pushed
the
platform_with_named_context
branch
2 times, most recently
from
cbd380d
to
4500137
Compare
cpuguy83
commented
Jul 29, 2022
cpuguy83
force-pushed
the
platform_with_named_context
branch
from
4500137
to
dfa3d06
Compare
cpuguy83
force-pushed
the
platform_with_named_context
branch
from
dfa3d06
to
ba4d7bc
Compare
|
Rebased this. |
Fixes image build contexts not respecting the platform specified in the Dockerfile `FROM --platform` argument. Before this change buildkit always resolves images using the target platform, but `FROM` may specifiy something else (such as $BUILDPLATFORM). Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
platform_with_named_context
branch
from
fafb194
to
cc6137c
Compare
|
Should be good to go now. |
tonistiigi
approved these changes
Aug 11, 2022
|
Ah this one might solve an issue I had when using build context with multi platform: https://github.com/crazy-max/goxx/pull/27/files#diff-38c01c28b3c4a6e8f3fc9076998609dfd55b8eed4902a8b6388ceb6a40cd86c5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes image build contexts not respecting the platform specified in the
Dockerfile
FROM --platformargument.Before this change buildkit always resolves images using the target
platform, but
FROMmay specifiy something else (such as$BUILDPLATFORM).