do not close sessions after client solve if pre-initialized #2995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes what appears to be a bug from an old refactor to allow shared sessions: moby@ef58b61 Without this, the session cannot really be shared effectively. Signed-off-by: coryb <cbennett@netflix.com>
coryb
force-pushed
the
fix-shared-session
branch
from
0ecc119
to
5674c2d
Compare
aaronlehmann
approved these changes
Aug 2, 2022
tonistiigi
approved these changes
Aug 2, 2022
coryb
added a commit
to coryb/hlb
that referenced
this pull request
Aug 3, 2022
This is now required after a fix to buildkit that prevented sessions from being shared my multiple solves. moby/buildkit#2995 A future optimization here might be to cache sessions for re-use within the hlb build rather than creating/closing for each solve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes what appears to be a bug from an old refactor to allow
shared sessions:
ef58b61
Without this, the session cannot really be shared effectively since it always closed by the first solve.
As discussed in slack: https://dockercommunity.slack.com/archives/C7S7A40MP/p1658286226946059
There are no current users outside the openllb/hlb project, so should not have an impact:
https://sourcegraph.com/search?q=context:global+SessionPreInitialized+-file:%28%5E%7C/%29vendor/+&patternType=literal
cc @aaronlehmann