Fix no-newline-at-end-of-RUN output issue #3072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This edge case was already handled for `CANCELED` or `ERROR`, but not `DONE` (or `CACHED`, which shouldn't have logs, but 馃し). Before: ```console $ docker buildx build --progress=plain --no-cache - <<<$'FROM bash\nRUN echo -n no newline' ... moby#5 [2/2] RUN echo -n no newline moby#5 0.268 no newline#5 DONE 0.3s ... ``` After: ```console $ docker buildx build --progress=plain --no-cache - <<<$'FROM bash\nRUN echo -n no newline' ... moby#5 [2/2] RUN echo -n no newline moby#5 0.268 no newline moby#5 DONE 0.3s ... ``` Signed-off-by: Tianon Gravi <admwiggin@gmail.com>
tianon
commented
Aug 30, 2022
| @@ -170,10 +170,10 @@ func (p *textMux) printVtx(t *trace, dgst digest.Digest) { | |||
| p.current = "" | |||
| v.count = 0 | |||
|
|
|||
| if v.logsPartial { | |||
| fmt.Fprintln(p.w, "") | |||
| } | |||
| if v.Error != "" { | |||
There was a problem hiding this comment.
My justification for this specific fix is that every single exit path of this if chain ends with some variation of fmt.Fprintf(p.w, "#%d ..., so it seems correct to make sure that every single path clears any partial line before outputting (even in the case of CACHED where I think logsPartial shouldn't ever be true).
tonistiigi
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This edge case was already handled for
CANCELEDorERROR, but notDONE(orCACHED, which shouldn't have logs, but 馃し).Before:
After: