dockerfile: allow named context for docker-image://scratch #3130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, there was no simple way to create an empty named context, requiring external steps such as creating an empty directory. This change allows a single one-line context to represent the empty state. This patch checks for docker-image://scratch, skipping image resolution and immediately returning the llb.Scratch state. Signed-off-by: Justin Chadwell <me@jedevc.com>
|
Is it actually a docker-image? Maybe it should be the raw keyword scratch instead |
I think this is fine as the name is reserved in hub as well. It is strange though that there is no actual image pushed.
|
tonistiigi
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mentioned by @ciaranmcnulty on the community slack.
Previously, there was no simple way to create an empty named context, requiring external steps such as creating an empty directory. This change allows a single one-line context to represent the empty state.
Example usage:
docker buildx build . --build-context alpine=docker-image://scratch