Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set a default PATH for Windows #3158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't set a default PATH for Windows #3158

wants to merge 1 commit into from
+52 −22

Commits on Nov 4, 2023

  1. Don't set a default PATH for Windows 

    Commit ecf070a updated DefaultPathEnv to return
platform specific values, but also defined a default PATH for Windows.

However, Windows does not have a default PATH, and the PATH to use must be set
by the container image. Also see moby/moby@3c177dc,
which removed the default PATH on Windows;

> This is deliberately empty on Windows as the default path will be set by
> the container. Docker has no context of what the default path should be.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    7399b8d View commit details
    Browse the repository at this point in the history