Do not unpack when there are no layers present. #3251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, can we have an integration test? |
manugupt1
force-pushed
the
scratch
branch
2 times, most recently
from
6cad12d
to
1c41a4d
Compare
tonistiigi
reviewed
Nov 3, 2022
Fixes: moby#3212 When trying to build scratch images and unpacking is true, containerd worker results in a panic. In order to avoid this, unpack only when src ref is not nil. Signed-off-by: Manu Gupta <manugupt1@gmail.com>
tonistiigi
approved these changes
Nov 3, 2022
AkihiroSuda
approved these changes
Nov 3, 2022
This was referenced Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3212 When trying to build scratch images and unpacking is true, containerd worker results in a panic. In order to avoid this, unpack only when num layers are greater than 0.
Signed-off-by: Manu Gupta manugupt1@gmail.com