add build history APIs #3294
add build history APIs #3294
Conversation
| // TODO: pinning | ||
| } | ||
|
|
||
| message Descriptor { |
There was a problem hiding this comment.
@AkihiroSuda I couldn't figure out how to import this type from containerd's proto definitions and not break compilation. Maybe you have better ideas on how to make it work so this duplication is not needed. I think the issue is that containerd uses Protobuild with some override mapping for import rules?
There was a problem hiding this comment.
I think duplicating the Descriptor definition is fine.
The duplicated amount is small, and the definition is unlikely going to be changed in a decade.
Also, I guess we can dedupe this later without breaking the compatibility?
There was a problem hiding this comment.
This also means that we would need to convert between different variants of descriptor on create and parse. To actually download the blob I'm planning to just enable the contentstore methods in control api. This means that either I will run into the same issue or some of the API endpoints will use one descriptor type and some the other.
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
build-history
branch
from
7eebbfd
to
dbee616
Compare
|
Moved this out of draft. This is only the first PR. Support for more properties and status stream for completed builds to follow. |
fixes #3050
For testing 2 new commands added to
buildctl:Will listen on event on new builds coming in and completing. If
--completedis passed, then shows previous builds stored on disk.Shows logs for an active build. RefID can be obtained with the
monitorcommand. Eventually, this would also work for completed builds.Signed-off-by: Tonis Tiigi tonistiigi@gmail.com