dockerfile: collect all dependencies as extra scan targets #3408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
approved these changes
Dec 14, 2022
Previously, we only checked for direct dependencies of the stage, and direct dependencies of any of it's parents. However, transitive dependencies would not be detected. To resolve this, we add a new findReachable function, to find all dependencies, including the transitive dependencies. The logic of this new function doesn't need to worry about circular dependencies: those should never be returned from the toDispatchState function as they are invalid. Signed-off-by: Justin Chadwell <me@jedevc.com>
jedevc
force-pushed
the
dockerfile-sbom-reachable
branch
from
3726dae
to
1b0587e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only checked for direct dependencies of the stage, and direct dependencies of any of its parents. However, transitive dependencies would not be detected.
To resolve this, we add a new
findReachablefunction, to find all dependencies, including the transitive dependencies. The logic of this new function doesn't need to worry about circular dependencies: those should never be returned from thetoDispatchStatefunction as they are invalid.Signed-off-by: Justin Chadwell me@jedevc.com