Fixes for provenance attestations #3413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
This allows matching spans from traces with provenance and status records. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
crazy-max
reviewed
Dec 15, 2022
| @@ -233,6 +233,7 @@ func FilterArgs(m map[string]string) map[string]string { | |||
| "cgroup-parent": {}, | |||
| "image-resolve-mode": {}, | |||
| "platform": {}, | |||
| "cache-imports": {}, | |||
There was a problem hiding this comment.
In follow-up we could look also do smth smarter and detect if fields contain sensistive info, otherwise we keep them.
There was a problem hiding this comment.
Frontends only have access to imports. Exports are handled directly by buildkit itself.
AkihiroSuda
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stepNnames. But this means that build step can't be combined with the same step in the status logs or opentelemetry. To fix that I added a map that contains mapping from original LLB digests for each step.type=localcache that is not reproducible.