dockerfile: apply no-cache to generated sboms #3414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If any of the stages that we would have generated sboms for match the no-cache filter, then the no-cache filter should also be applied to the sbom generation. Signed-off-by: Justin Chadwell <me@jedevc.com>
Why can't we do this as well? |
The fallback scanner should also respect the no-cache value if set. Signed-off-by: Justin Chadwell <me@jedevc.com>
Have updated to do this buildkit side. We also need an update buildx side so that |
tonistiigi
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Fixes #3412 (cc @tianon)
If any of the stages that we would have generated sboms for match the no-cache filter, then the no-cache filter should also be applied to the sbom generation.
Note: this fix only applies for dockerfile-generated SBOMs - fallback SBOMs generated by buildkit won't use the
no-cachefrontend attribute.