[Windows] Add Windows service support #3545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriel-samfira
force-pushed
the
add-windows-service-support
branch
from
2682641
to
6302a40
Compare
gabriel-samfira
force-pushed
the
add-windows-service-support
branch
3 times, most recently
from
cd7df75
to
a726571
Compare
gabriel-samfira
force-pushed
the
add-windows-service-support
branch
from
a726571
to
dbdeffb
Compare
This branch adds the abilitity to run buildkitd as a Windows service. Most of this code is shared with dockerd and containerd, with slight changes to adapt it to buildkit. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
gabriel-samfira
force-pushed
the
add-windows-service-support
branch
from
dbdeffb
to
d826beb
Compare
|
Moved this branch to ready for review, as it doesn't really depend on anything and doesn't really hurt/add any complexity if it does merge. This branch simply enables buildkitd to run as a windows service and be managed by the Windows service manager. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds the abilitity to run buildkitd as a Windows service. Most of this code is shared with dockerd and containerd, with slight changes to adapt it to buildkit.
Not sure if this should be merged before everything else gets in and buildkit actually runs on Windows, so marking this as draft.
Signed-off-by: Gabriel Adrian Samfira gsamfira@cloudbasesolutions.com