http: ensure HEAD and GET requests have same headers #3745
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3739
Currently,
GET
requests getAccept-Encoding: gzip
added in stdlib, but forHEAD
requests, that does not happen https://github.com/golang/go/blob/go1.20.2/src/net/http/transport.go#L2575 . Github server will return different Etag headers based on different request headers(likely handled by separate services), and does not matchIf-None-Match
againstEtag
from different request.