Add client opts to enable system certificates #3760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, this splits out WithCredentials into separate methods: - WithCredentials configures the client credentials presented to the server - WithServerConfig configures the name and ca certificate to check the server's certificate against - WithServerConfigSystem configures the name to check the server's certificate against - the ca certificate is automatically pulled from the system store. Signed-off-by: Justin Chadwell <me@jedevc.com>
jedevc
force-pushed
the
with-credentials-system-certs
branch
from
7827c16
to
8f66706
Compare
tonistiigi
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, this splits out WithCredentials into separate methods:
This essentially splits out the different possible TLS combinations into: