Avoid panic on parallel walking on DefinitionOp #3813
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefinitionOp.inputCache
can be shared and written among calls ofDefinitionOp.Inputs()
.When walking vertices of DefinitionOp in parallel using
DefinitionOp.Inputs()
, it causes panic as of now.This commit fixes this issue by using
sync.Map
forDefinitionOp.inputCache
allowing it written in parallel.