[v0.11] provenance: fix possible empty digest access #3899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the digest for an ImageSource is the empty string, then calling `Digest.Algorithm` will panic at runtime. This scenario *can* happen if `ResolveImageConfig` returns an empty digest, but correctly returns a config object. This doesn't occur in buildkit directly, however, buildkit-in-moby implements a custom worker which also performs image lookups on local images, in which case the digest for the index may not be available (though this may be possible with the containerd image store?). Therefore, we shouldn't assume that the digest is always available in buildkit, and should instead check that is valid before inserting it into the digest set (which is already an optional map). Signed-off-by: Justin Chadwell <me@jedevc.com> (cherry picked from commit e398498) Signed-off-by: Justin Chadwell <me@jedevc.com>
crazy-max
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃崚 Cherry-pick of #3896.