gateway: wrap ExecProcessServer Send calls with a mutex #3940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
reviewed
Jun 8, 2023
tonistiigi
reviewed
Jun 8, 2023
matiasinsaurralde
force-pushed
the
exec-process-server-send-lock
branch
from
eab2cca
to
85f1ed2
Compare
|
@tonistiigi Thanks for the review, I've updated the code based on the suggestions, also ran tests implemented in #3832 incorporating these changes and they look good (no |
matiasinsaurralde
force-pushed
the
exec-process-server-send-lock
branch
from
85f1ed2
to
3092649
Compare
According to gRPC ClientStream interface documentation it isn't safe to call SendMsg on the same stream in different goroutines, which we do in LLBBridgeServer implementation. The generated bindings don't provide a mechanism to avoid this scenario. This change wraps LLBBridgeServer implementation with a custom locking behavior: https://pkg.go.dev/google.golang.org/grpc@v1.53.0#ClientStream.SendMsg Signed-off-by: Matias Insaurralde <matias@insaurral.de>
matiasinsaurralde
force-pushed
the
exec-process-server-send-lock
branch
from
3092649
to
8a28fe6
Compare
tonistiigi
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to gRPC ClientStream interface documentation it isn't safe to call SendMsg on the same stream in different goroutines, which we do in LLBBridgeServer implementation. The generated bindings don't provide a mechanism to avoid this scenario. This change wraps LLBBridgeServer implementation with a custom locking behavior.
Should fix the scenario described by @sipsma in #3832