handle missing provenance for non-evaluated result #3945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedevc
approved these changes
Jun 22, 2023
|
LGTM once #3860 merges |
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
If resultProxy has been created but the result has not been evaluated then it shouldn't show missing provenance error for that result. This patch works together with previous one that fixes error reporting on provenance creation. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
fix-missing-provenance
branch
from
4f8717e
to
60b3aa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3928
fixes #3562
depends on #3860
If resultProxy has been created but the result has not been
evaluated then it shouldn't show missing provenance error
for that result.
This patch works together with the previous one that fixes
error reporting on provenance creation.
https://github.com/moby/buildkit/compare/master...tonistiigi:buildkit:fix-missing-provenance?expand=1#diff-2fc2e99eea0899fac8a14da1878d67aa8520bed09be4de598226d4d29450d6c8R279